Skip to content

Commit

Permalink
Resolve a bug of invalid presentation of the add instance button in t…
Browse files Browse the repository at this point in the history
…he instance composer when using Firefox (Issue #5689, PR #5703)

# Description

Beside make it the same between browsers I also aligned image to the text, as it was a little of centre which was striking me lately

closes #5689

# Self Check:

Strike through any lines that are not applicable (`~~line~~`) then check the box

- [ ] Attached issue to pull request
- [ ] Changelog entry
- [ ] Code is clear and sufficiently documented
- [ ] Sufficient test cases (reproduces the bug/tests the requested feature)
- [ ] Correct, in line with design
- [ ] End user documentation is included or an issue is created for end-user documentation (add ref to issue here: )
<img width="1436" alt="Screenshot 2024-04-23 at 12 28 55" src="https://github.com/inmanta/web-console/assets/113331659/c8ebb45b-1221-4f65-a6f3-073a72a0d9b4">
  • Loading branch information
matborowczyk authored and inmantaci committed Apr 23, 2024
1 parent cdc6df3 commit 88ea32e
Show file tree
Hide file tree
Showing 2 changed files with 19 additions and 6 deletions.
6 changes: 6 additions & 0 deletions changelogs/unreleased/5689-add-instance-button-bug.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
description: "Resolve a bug of invalid presentation of the add instance button in the instance composer when using Firefox"
issue-nr: 5689
change-type: patch
destination-branches: [master, iso7]
sections:
bugfix: "{{description}}"
19 changes: 13 additions & 6 deletions src/UI/Components/Diagram/components/Toolbar.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -54,12 +54,19 @@ const Toolbar = ({
aria-label="new-entity-button"
isDisabled={!editable}
>
<img
src={entityIcon}
alt="Create new entity icon"
aria-label="new-entity-icon"
/>{" "}
{words("inventory.addInstance.button")}
<Flex alignItems={{ default: "alignItemsCenter" }}>
<FlexItem
spacer={{ default: "spacerXs" }}
style={{ width: "16px", height: "20px" }}
>
<img
src={entityIcon}
alt="Create new entity icon"
aria-label="new-entity-icon"
/>
</FlexItem>
<FlexItem>{words("inventory.addInstance.button")}</FlexItem>
</Flex>
</IconButton>
</Tooltip>
</FlexItem>
Expand Down

0 comments on commit 88ea32e

Please sign in to comment.