Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: ink layout #23

Merged
merged 3 commits into from
Nov 21, 2024
Merged

feat: ink layout #23

merged 3 commits into from
Nov 21, 2024

Conversation

fran-ink
Copy link
Contributor

@fran-ink fran-ink commented Nov 20, 2024 •
edited
Loading

missing a couple of things to make it really nice:

  1. Better content in the main section
  2. Button on the top corner (like in the mock ups)

image

@fran-ink fran-ink requested a review from a team as a code owner November 20, 2024 22:01
@fran-ink fran-ink changed the title feat: ink layout draft: feat: ink layout Nov 20, 2024
@fran-ink fran-ink marked this pull request as draft November 20, 2024 22:02
@fran-ink fran-ink changed the title draft: feat: ink layout feat: ink layout Nov 20, 2024
@fran-ink fran-ink force-pushed the feat/layout branch 2 times, most recently from 4565e30 to 194bd40 Compare November 21, 2024 14:24
@fran-ink fran-ink marked this pull request as ready for review November 21, 2024 17:20
ink-victor
ink-victor approved these changes Nov 21, 2024
View reviewed changes
Copy link
Contributor

@ink-victor ink-victor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@ink-victor ink-victor merged commit 657c67a into main Nov 21, 2024
4 checks passed
@ink-victor ink-victor deleted the feat/layout branch November 21, 2024 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ink-victor ink-victor ink-victor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fran-ink @ink-victor