Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: modal component #21

Merged
merged 1 commit into from
Nov 20, 2024
Merged

feat: modal component #21

merged 1 commit into from
Nov 20, 2024

Conversation

fran-ink
Copy link
Contributor

@fran-ink fran-ink commented Nov 20, 2024

main usage is:

<Modal id="x">
  ({ closeModal }) => ... // modal content goes here
</Modal>

We can then open it with:

const { openModal } = useModalContext("x");

The ModalLayout namespace suggests layouts to use inside the modal (currently only one, CallToAction), but you can put whatever you want in the modal

image

image

@fran-ink fran-ink requested a review from a team as a code owner November 20, 2024 17:35
Copy link
Contributor

@ink-victor ink-victor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

@fran-ink fran-ink merged commit 33a536e into main Nov 20, 2024
4 checks passed
@fran-ink fran-ink deleted the feat/modal branch November 20, 2024 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants