Visibility matching on SLElement #232
Conversation
| @@ -135,6 +135,13 @@ - (BOOL)matchesObject:(NSObject *)object | |||
| NSAssert(_matchesObject, @"matchesObject called on %@, which has no _matchesObject predicate", self); | |||
| BOOL matchesObject = _matchesObject(object); | |||
|
|
|||
| // Non-UIView objects are assumed to be "not hidden" | |||
| if (self.matchOnlyIfVisible) { | |||
There was a problem hiding this comment.
You'd want to use -[NSObject slAccessibilityIsVisible], and check all objects, here--there are a bunch of reasons why objects, including non-views, might not be visible from both the user's and UIAutomation's perspectives.
(Making this change would cause matchOnlyIfVisible to fail in non-portrait orientations (#135), but would be generally more robust. It would be nice if you could fall back to UIAElement.isVisible as does -[SLElement isVisible] but I'm not sure how you'd do that given that matching takes place on the main thread.)
|
Is the scenario here that you have two elements in the hierarchy with the same attributes, only one is visible and one isn't? How often would you say this comes up? An alternative to building this functionality into |
|
Will use |
Added functionality to SLElement which further filters the matching routine based on the visibility of a view.