Ax parent #190
Open
Ax parent #190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Need to fill out subliminal methods for abstracting these concepts.
This has basic docs (needs fleshing out). But a working version of a solution for child and parent accessibility elements, along with implementations for UINavigationBar and UITableViewCell.
Closed
On iOS 6, table view cells themselves appear in the accessibility hierarchy. On iOS 7, mock cells (instances of `UITableViewCellAccessibilityElement`) appear in the hierarchy instead.
Documented view and accessibility view heirarchy for iOS 6 and 7 for UITableViewCells. It is slightly different and needed to be accounted for.
Extended to all elements and allowed `SLTableViewCell` to override.
| @@ -376,6 +376,9 @@ @implementation UITableViewCell (SLAccessibilityHierarchy) | |||
| - (BOOL)classForcesPresenceOfMockingViewsInAccessibilityHierarchy { | |||
| return YES; | |||
| } | |||
| - (BOOL)classForcesPresenceInAccessibilityHierarchy { | |||
There was a problem hiding this comment.
I'm curious to see that you reverted the version-specific checks. Is there no difference between versions? How can both instances and their mock views be present in the hierarchy? (It'd be nice to describe whatever the answer is in a comment in the source.)
There was a problem hiding this comment.
Also can you add case(s) to SLElementMatchingTest exercising whatever this addition fixed?
|
You've made the core functionality here pretty elegant @jzucker2! 👍 Most of my feedback is about making the tests as straightforward:
Thanks for iterating on this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a proposed solution to this issue: #189