Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor controller logic from player controller to universal character controller #290

Merged
merged 46 commits into from
May 28, 2020
Merged

Refactor controller logic from player controller to universal character controller #290

merged 46 commits into from
May 28, 2020
+344 −266

Conversation

Segelzwerg
Copy link
Collaborator

This is the first step for the movement to be universal for players and NPCs-

closes #262

Segelzwerg added 30 commits May 22, 2020 21:28
REFACTOR: move movement to CharacterController
3c7772f
REFACTOR: rotation so input method is not relevant
a15b7e5
REFACTOR: move rotation to character controller
53c6fe9
REFACTOR: extract method for playing sounds
19077d4
REFACTOR: move character sounds to character controller
8950a7c
REFACTOR: move check moveable terrain
37d0470
FIX: automatic added loop dependency
541f156
REFACTOR: move jump
6c56d97
FIX: typo
84d0cf9
REFACTOR: use proper out variable
a15e16f
REFACTOR: simplify ifs
69d4abf
REFACTOR: simplify another if
c180f52
FIX: use correct verb for method name
ba6f5c5
REFACTOR: move sensitivity to outer scope
94dfb97
REFACTOR: move camera movement back to player controller
3f672f2
REFACTOR: move is running flag
20691b3
REFACTOR: move properties to outer scope
dfd4d4c
REFACTOR: remove redundant code
a6610d3
REFACTOR: move is airborne flag
8926847
REFACTOR: move rigid body to character controller
a8e6611
ADD: rigid body requirement
587d140
FIX: typo
d8caac8
REFACTOR: move is sneaking flag
b110ef4
REMOVE: unused flag
6ceebbc
REMOVE: more unused fields
7ecc106
REFACTOR: move ground detector
9fa7fae
REFACTOR: move jump power to outer scope
eaffd55
REMOVE: unused parameter
fc9bb41
REMOVE: unused code
20fc2ea
REFACTOR: move body field
decf698
@Segelzwerg Segelzwerg added the rework Feature rework or major overhaul label May 22, 2020
@Segelzwerg Segelzwerg requested a review from iTitus May 22, 2020 21:16
@Segelzwerg Segelzwerg self-assigned this May 22, 2020
@Segelzwerg Segelzwerg mentioned this pull request May 23, 2020
Merged
Segelzwerg
Segelzwerg commented May 28, 2020
View reviewed changes
Copy link
Collaborator Author

@Segelzwerg Segelzwerg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rider moves the rigidbody automatically.

@iTitus iTitus merged commit 1cd0351 into npc/production May 28, 2020
@iTitus iTitus deleted the npc/controller branch May 28, 2020 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iTitus iTitus

Assignees

@Segelzwerg Segelzwerg

Labels
rework Feature rework or major overhaul
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Segelzwerg @iTitus