Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove bluebird dependency #27

Merged
merged 1 commit into from
Feb 24, 2025
Merged

Remove bluebird dependency #27

merged 1 commit into from
Feb 24, 2025

Conversation

joon9823
Copy link
Contributor

@joon9823 joon9823 commented Feb 24, 2025

Summary by CodeRabbit

  • Chores
    • Streamlined asynchronous operations by replacing an external dependency with native timer functionality, ensuring optimal efficiency and maintainability without affecting user experience.

@joon9823 joon9823 requested a review from ALPAC-4 February 24, 2025 08:08
Copy link

coderabbitai bot commented Feb 24, 2025

Walkthrough

This pull request removes the Bluebird dependency from the project by deleting both its runtime and type definition references from the package.json file. Additionally, import statements in several modules (msgs and workers) have been updated to use Node.js’s built-in timers/promises module for delay functionality instead of Bluebird. The changes solely affect dependency management and module imports, leaving the core logic and asynchronous operations unchanged.

Changes

File(s) Change Summary
package.json Removed "bluebird": "^3.7.2" from dependencies and "@types/bluebird": "^3.5.42" from devDependencies.
src/msgs/timeout.ts, src/msgs/updateClient.ts, src/workers/chain.ts, src/workers/wallet.ts Updated import statements: changed delay import from 'bluebird' to { setTimeout as delay } from 'timers/promises'.

Suggested reviewers

  • ALPAC-4

Poem

I'm a nimble rabbit, hopping through code with delight,
Saying goodbye to Bluebird, as Node's timers shine so bright.
A swift new delay with promises built in,
My little paws tap on keys with a joyful spin.
Celebrating this shift, I nibble on changes all day—
Hoppy coding adventures light my curious way!


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 62b5214 and 8410dc9.

⛔ Files ignored due to path filters (1)
  • package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing (5)
  • package.json (0 hunks)
  • src/msgs/timeout.ts (1 hunks)
  • src/msgs/updateClient.ts (1 hunks)
  • src/workers/chain.ts (1 hunks)
  • src/workers/wallet.ts (1 hunks)
💤 Files with no reviewable changes (1)
  • package.json
✅ Files skipped from review due to trivial changes (4)
  • src/msgs/updateClient.ts
  • src/workers/wallet.ts
  • src/workers/chain.ts
  • src/msgs/timeout.ts
⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: Analyze (javascript-typescript)

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@ALPAC-4 ALPAC-4 merged commit 1246caf into main Feb 24, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants