-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validate source directory existence. #252
base: main
Are you sure you want to change the base?
Conversation
WalkthroughThe changes enhance error handling in the main script by adding a validation step to check for the existence of the source directory before proceeding with file operations. This modification ensures that the script gracefully handles scenarios where the source directory is missing, preventing potential runtime errors and providing clear console feedback. Changes
Poem
Finishing Touches
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
_api/src/main.ts (1)
31-34
: Consider these refinements to enhance the error handling.While the current implementation is functional, consider these improvements:
- Use
process.stderr.write
for error output- Add more context about the impact
- Consider moving the validation to a separate function
+function validateSourceDirectory(srcDir: string): void { + if (!existsSync(srcDir)) { + process.stderr.write( + `Error: Source directory not found: ${srcDir}\n` + + `Please ensure the directory exists before running this script.\n` + ); + process.exit(1); + } +} + -if (!existsSync(srcDir)) { - console.error(`Source directory does not exist: ${srcDir}`); - process.exit(1); -} +validateSourceDirectory(srcDir);
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
_api/src/main.ts
(2 hunks)
🔇 Additional comments (2)
_api/src/main.ts (2)
16-16
: LGTM! Appropriate import for directory validation.The addition of
existsSync
from the Node.jsfs
module is the correct choice for synchronous directory existence checking.
28-34
: LGTM! Early validation prevents undefined behavior.The validation is correctly placed before any file operations and uses appropriate error handling with a non-zero exit code.
Summary by CodeRabbit