Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(adopt-styles): use traditional style on ios #2144

Merged
merged 6 commits into from
Nov 24, 2023

Conversation

igomezal
Copy link
Contributor

What I did

We have detected problems on iOS 16.4 and newer versions where the overlays styles were not applied to the overlay and only the basic overlay were keep.

To test the fix we have patched it in our component and tested it with our customers and we have not detected any new error since we applied it.

We have not found a way to isolated the problem and replicate it as the problem was not happening in all the sessions, it seems some kind of race condition when applying the styles to the overlay.

To mitigate this issue I propose this PR to avoid applying the styles using adopt styles on ios devices.

Copy link

changeset-bot bot commented Nov 21, 2023

🦋 Changeset detected

Latest commit: 2f9a553

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@lion/ui Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@CLAassistant
Copy link

CLAassistant commented Nov 21, 2023

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@tlouisse tlouisse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! Could you maybe add a description of the bug above the exception and a changeset? Then we can merge it.

@igomezal igomezal force-pushed the fix/useTraditionalStyleOnIOS branch from a6a2204 to caa7ac8 Compare November 21, 2023 21:45
@igomezal
Copy link
Contributor Author

Thanks for the fix! Could you maybe add a description of the bug above the exception and a changeset? Then we can merge it.

I have included the changeset and the description in the code.

@tlouisse tlouisse merged commit 322b065 into ing-bank:master Nov 24, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants