fix(overlay-controller): do not scroll to invoker if it is visible (#…

…2155) * fix(overlay-controller): do not scroll to invoker if it is visible on screen When closing an overlay, srollIntoView forced the invoker element to be placed in the middle of the screen. This fix prevents the scroll if the invoker is already visible, but still scrolls it into view if needed. * chore: changeset
ing-bank · Dec 11, 2023 · c80bca7 · c80bca7
1 parent d997e52
commit c80bca7
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/.changeset/hot-otters-push.md b/.changeset/hot-otters-push.md
@@ -0,0 +1,5 @@
+---
+'@lion/ui': patch
+---
+
+Fix scroll behavior when closing an overlay
diff --git a/packages/ui/components/overlays/src/OverlayController.js b/packages/ui/components/overlays/src/OverlayController.js
@@ -933,7 +933,7 @@ export class OverlayController extends EventTarget {
 
     if (this.elementToFocusAfterHide) {
       this.elementToFocusAfterHide.focus();
-      this.elementToFocusAfterHide.scrollIntoView({ block: 'center' });
+      this.elementToFocusAfterHide.scrollIntoView({ block: 'nearest' });
     } else {
       /** @type {HTMLElement} */ (this.__activeElementRightBeforeHide).blur();
     }