Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(code): Some WAL entries fail to decode #840

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ancazamfir
Copy link
Collaborator

Closes: #XXX
Sometime wal entries fail to decode with errors like this:

2025-02-07T20:30:44.054030Z ERROR node{moniker=test-2}:wal{height=144}: Failed to decode WAL entry 4: failed to fill whole buffer

Looks like for PrevoteTimeLimit and PrecommitTimeLimit we still write something to the WAL (just the tag) and later fail to decode.

  • Add test that shows the error (needs actual failure, cleanup)
  • Fix the error

PR author checklist

For all contributors

For external contributors

Copy link

codecov bot commented Feb 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.16%. Comparing base (614a46c) to head (aebabcb).

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #840      +/-   ##
==========================================
+ Coverage   75.79%   76.16%   +0.36%     
==========================================
  Files         169      169              
  Lines       14682    14683       +1     
==========================================
+ Hits        11128    11182      +54     
+ Misses       3554     3501      -53     
Flag Coverage Δ
integration 75.87% <ø> (+0.36%) ⬆️
mbt 20.63% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
core ∅ <ø> (∅)
engine ∅ <ø> (∅)
app ∅ <ø> (∅)
starknet ∅ <ø> (∅)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant