Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(code/sync): When decide via sync skip commit timeout #839

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ancazamfir
Copy link
Collaborator

Closes: #XXX

When a decision is made via value sync, skip the commit timeout and notify host immediately


PR author checklist

For all contributors

For external contributors

Copy link

codecov bot commented Feb 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.82%. Comparing base (614a46c) to head (7470351).

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #839      +/-   ##
==========================================
+ Coverage   75.79%   75.82%   +0.03%     
==========================================
  Files         169      170       +1     
  Lines       14682    14696      +14     
==========================================
+ Hits        11128    11143      +15     
+ Misses       3554     3553       -1     
Flag Coverage Δ
integration 75.54% <ø> (+0.03%) ⬆️
mbt 20.63% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
core ∅ <ø> (∅)
engine ∅ <ø> (∅)
app ∅ <ø> (∅)
starknet ∅ <ø> (∅)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant