Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

imp: minimize prost dependency #998

Merged
merged 1 commit into from
Dec 1, 2023
Merged

imp: minimize prost dependency #998

merged 1 commit into from
Dec 1, 2023

Conversation

Farhad-Shabani
Copy link
Member

@Farhad-Shabani Farhad-Shabani commented Dec 1, 2023

Closes: #997

Integration tests: informalsystems/basecoin-rs#147


PR author checklist:

  • Added changelog entry, using unclog.
  • Added tests.
  • Linked to GitHub issue.
  • Updated code comments and documentation (e.g., docs/).
  • Tagged one reviewer who will be the one responsible for shepherding this PR.

Reviewer checklist:

  • Reviewed Files changed in the GitHub PR explorer.
  • Manually tested (in case integration/unit/mock tests are absent).

@Farhad-Shabani Farhad-Shabani added this to the v0.49.0 milestone Dec 1, 2023
Copy link

codecov bot commented Dec 1, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (fe9a26b) 70.86% compared to head (f172a56) 70.90%.

Files Patch % Lines
ibc-clients/ics07-tendermint/src/client_state.rs 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #998      +/-   ##
==========================================
+ Coverage   70.86%   70.90%   +0.04%     
==========================================
  Files         178      178              
  Lines       17918    17905      -13     
==========================================
- Hits        12698    12696       -2     
+ Misses       5220     5209      -11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Farhad-Shabani Farhad-Shabani merged commit 2259108 into main Dec 1, 2023
14 checks passed
@Farhad-Shabani Farhad-Shabani deleted the farhad/to-vec branch December 1, 2023 16:13
Farhad-Shabani added a commit that referenced this pull request Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Minimize prost dependency via ToVec trait
2 participants