Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ibc-core): copy substitute consensus state during client recovery #1197

Merged
merged 17 commits into from
Apr 26, 2024

Pass substitute consensus state into client recovery methods

005ae23
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Merged

fix(ibc-core): copy substitute consensus state during client recovery #1197

Pass substitute consensus state into client recovery methods
005ae23
Select commit
Loading
Failed to load commit list.
GitHub Actions / clippy failed Apr 25, 2024 in 0s

clippy

1 error

Details

Results

Message level Amount
Internal compiler error 0
Error 1
Warning 0
Note 0
Help 0

Versions

  • rustc 1.77.2 (25ef9e3d8 2024-04-09)
  • cargo 1.77.2 (e52e36006 2024-03-26)
  • clippy 0.1.77 (25ef9e3 2024-04-09)

Annotations

Check failure on line 86 in ibc-core/ics02-client/src/handler/recover_client.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

the trait bound `ibc_primitives::proto::Any: core::convert::From<<<Ctx as ibc_core_host::ExecutionContext>::E as ibc_core_client_context::ClientValidationContext>::ConsensusStateRef>` is not satisfied 

error[E0277]: the trait bound `ibc_primitives::proto::Any: core::convert::From<<<Ctx as ibc_core_host::ExecutionContext>::E as ibc_core_client_context::ClientValidationContext>::ConsensusStateRef>` is not satisfied
  --> ibc-core/ics02-client/src/handler/recover_client.rs:86:36
   |
86 |         substitute_consensus_state.into(),
   |                                    ^^^^ the trait `core::convert::From<<<Ctx as ibc_core_host::ExecutionContext>::E as ibc_core_client_context::ClientValidationContext>::ConsensusStateRef>` is not implemented for `ibc_primitives::proto::Any`, which is required by `<<Ctx as ibc_core_host::ExecutionContext>::E as ibc_core_client_context::ClientValidationContext>::ConsensusStateRef: core::convert::Into<_>`
   |
   = note: required for `<<Ctx as ibc_core_host::ExecutionContext>::E as ibc_core_client_context::ClientValidationContext>::ConsensusStateRef` to implement `core::convert::Into<ibc_primitives::proto::Any>`
help: consider extending the `where` clause, but there might be an alternative better way to express this requirement
   |
66 |     Ctx: ExecutionContext, ibc_primitives::proto::Any: core::convert::From<<<Ctx as ibc_core_host::ExecutionContext>::E as ibc_core_client_context::ClientValidationContext>::ConsensusStateRef>
   |                          ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
View more details on GitHub Actions