Remove redundant allow(clippy::too_many_arguments) (#675)

informalsystems · May 11, 2023 · 455029d · 455029d
1 parent 07ddc96
commit 455029d
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 8 deletions.
diff --git a/.changelog/unreleased/improvements/674-remove-too-many-args.md b/.changelog/unreleased/improvements/674-remove-too-many-args.md
@@ -0,0 +1,2 @@
+- Remove redundant #[allow(clippy::too_many_arguments)]
+ ([#674](https://github.com/cosmos/ibc-rs/issues/674))
diff --git a/crates/ibc/src/applications/transfer/context.rs b/crates/ibc/src/applications/transfer/context.rs
@@ -114,7 +114,6 @@ pub fn cosmos_adr028_escrow_address(port_id: &PortId, channel_id: &ChannelId) ->
     hash
 }
 
-#[allow(clippy::too_many_arguments)]
 pub fn on_chan_open_init_validate(
     ctx: &impl TokenTransferValidationContext,
     order: Order,
@@ -147,7 +146,6 @@ pub fn on_chan_open_init_validate(
     Ok(())
 }
 
-#[allow(clippy::too_many_arguments)]
 pub fn on_chan_open_init_execute(
     _ctx: &mut impl TokenTransferExecutionContext,
     _order: Order,
@@ -160,7 +158,6 @@ pub fn on_chan_open_init_execute(
     Ok((ModuleExtras::empty(), Version::new(VERSION.to_string())))
 }
 
-#[allow(clippy::too_many_arguments)]
 pub fn on_chan_open_try_validate(
     _ctx: &impl TokenTransferValidationContext,
     order: Order,
@@ -184,7 +181,6 @@ pub fn on_chan_open_try_validate(
     Ok(())
 }
 
-#[allow(clippy::too_many_arguments)]
 pub fn on_chan_open_try_execute(
     _ctx: &mut impl TokenTransferExecutionContext,
     _order: Order,
@@ -242,6 +238,7 @@ pub fn on_chan_close_init_validate(
 ) -> Result<(), TokenTransferError> {
     Err(TokenTransferError::CantCloseChannel)
 }
+
 pub fn on_chan_close_init_execute(
     _ctx: &mut impl TokenTransferExecutionContext,
     _port_id: &PortId,

diff --git a/crates/ibc/src/core/router.rs b/crates/ibc/src/core/router.rs
@@ -132,7 +132,6 @@ impl ModuleExtras {
 
 /// The trait that defines an IBC application
 pub trait Module: Debug {
-    #[allow(clippy::too_many_arguments)]
     fn on_chan_open_init_validate(
         &self,
         order: Order,
@@ -143,7 +142,6 @@ pub trait Module: Debug {
         version: &Version,
     ) -> Result<Version, ChannelError>;
 
-    #[allow(clippy::too_many_arguments)]
     fn on_chan_open_init_execute(
         &mut self,
         order: Order,
@@ -154,7 +152,6 @@ pub trait Module: Debug {
         version: &Version,
     ) -> Result<(ModuleExtras, Version), ChannelError>;
 
-    #[allow(clippy::too_many_arguments)]
     fn on_chan_open_try_validate(
         &self,
         order: Order,
@@ -165,7 +162,6 @@ pub trait Module: Debug {
         counterparty_version: &Version,
     ) -> Result<Version, ChannelError>;
 
-    #[allow(clippy::too_many_arguments)]
     fn on_chan_open_try_execute(
         &mut self,
         order: Order,
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1,2 @@
		- Remove redundant #[allow(clippy::too_many_arguments)]
		([#674](https://github.com/cosmos/ibc-rs/issues/674))