nit: remove now redundant clones

informalsystems · Dec 18, 2023 · 0052973 · 0052973
1 parent c27cbe4
commit 0052973
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/ibc-clients/ics07-tendermint/src/client_state.rs b/ibc-clients/ics07-tendermint/src/client_state.rs
@@ -199,7 +199,7 @@ impl ClientStateCommon for ClientState {
     ) -> Result<(), ClientError> {
         let merkle_path = apply_prefix(prefix, vec![path.to_string()]);
         let merkle_proof =
-            MerkleProof::try_from(proof.clone()).map_err(ClientError::InvalidCommitmentProof)?;
+            MerkleProof::try_from(proof).map_err(ClientError::InvalidCommitmentProof)?;
 
         merkle_proof
             .verify_membership(
@@ -221,7 +221,7 @@ impl ClientStateCommon for ClientState {
     ) -> Result<(), ClientError> {
         let merkle_path = apply_prefix(prefix, vec![path.to_string()]);
         let merkle_proof =
-            MerkleProof::try_from(proof.clone()).map_err(ClientError::InvalidCommitmentProof)?;
+            MerkleProof::try_from(proof).map_err(ClientError::InvalidCommitmentProof)?;
 
         merkle_proof
             .verify_non_membership(&self.0.proof_specs, root.clone().into(), merkle_path)

diff --git a/ibc-core/ics23-commitment/types/src/commitment.rs b/ibc-core/ics23-commitment/types/src/commitment.rs
@@ -130,7 +130,7 @@ impl<'a> TryFrom<&'a CommitmentProofBytes> for MerkleProof {
     type Error = CommitmentError;
 
     fn try_from(value: &'a CommitmentProofBytes) -> Result<Self, Self::Error> {
-        Protobuf::<RawMerkleProof>::decode(value.bytes.as_slice())
+        Protobuf::<RawMerkleProof>::decode(value.as_ref())
             .map_err(|e| CommitmentError::DecodingFailure(e.to_string()))
     }
 }