Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove cosmos-specific implementation of client update CLI #512

Merged
merged 1 commit into from
Dec 24, 2024

Conversation

ljoss17
Copy link
Contributor

@ljoss17 ljoss17 commented Dec 24, 2024

Closes: #511

Description

This PR removes the Cosmos-specific implementation of client update CLI and uses the generic one instead


PR author checklist:

  • Added changelog entry, using unclog.
  • Added tests: integration (for Hermes) or unit/mock tests (for modules).
  • Linked to GitHub issue.
  • Updated code comments and documentation (e.g., docs/).
  • Tagged one reviewer who will be the one responsible for shepherding this PR.

Reviewer checklist:

  • Reviewed Files changed in the GitHub PR explorer.
  • Manually tested (in case integration/unit/mock tests are absent).

@ljoss17 ljoss17 merged commit 9b3d92f into main Dec 24, 2024
10 checks passed
@ljoss17 ljoss17 deleted the luca_joss/remove-cosmos-specific-client-update-cli branch December 24, 2024 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove Cosmos-specific implementation of client update
1 participant