feat(parser.prometheusremotewrite): v1, atomic native histogram #16493
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Split v1/v2 metric parser version for
prometheusremotewrite
format, emulating that inprometheus
format.V2 is the original, existing behavior.Code is directly lifted from the original
plugins/parsers/prometheusremotewrite/parser.go
.This PR implements V1, which emulates the dense behavior of
prometheus
format v1. It:value
for value fieldNote that
prometheusremotewrite
V1 DOES NOT convert classic histogram/summary into one single telegraf metric as in the case ofprometheus
V1, because in a remote write request, a classic histogram is already broken up into various sub-metrics (counters/gauges), and they could even be in different remote write batches. However, it does conserves the dense behavior for native histogram.--
This PR partially inplemented the design in #16120 and partially supercedes PR #16121, as a follow up to resolve this comment and design discussion in slack channel with @srebhan.
A PR for
prometheusremotewrite
serializer can be found at #16494Checklist
Related issues
resolves #16120