chore(inputs.statsd): Refactor internal stats into their own struct #16419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 21, 2025
|
Thanks so much for the pull request! |
…ruct Summary: Later in this stack of diffs, I add a field named `MaxConnections` to `Statsd` because it controls the max number of connections for all listener types, not just TCP listeners. That creates a naming collision with the existing field named `MaxConnections`, which is an internal stat tracker. This diff eliminates that name collision by encapsulating all of `Statsd`'s internal stat trackers in a struct. Test Plan: Existing unit tests pass.
Manbeardo
changed the title
|
!signed-cla |
|
Download PR build artifacts for linux_amd64.tar.gz, darwin_arm64.tar.gz, and windows_amd64.zip. 📦 Click here to get additional PR build artifactsArtifact URLs |
DStrand1
approved these changes
Jan 22, 2025
DStrand1
added
the
ready for final review
srebhan
changed the title
telegraf-tiger
bot
added
area/statsd
chore
plugin/input
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Later in this stack of diffs, I add a field named
MaxConnectionstoStatsdbecause it controls the max number of connections for all listener types, not just TCP listeners. That creates a naming collision with the existing field namedMaxConnections, which is an internal stat tracker. This diff eliminates that name collision by encapsulating all ofStatsd's internal stat trackers in a struct.Test Plan:
Existing unit tests pass.
Stack created with Sapling. Best reviewed with ReviewStack.