Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(inputs.fireboard): Revert typo fix as the typo is returned in the actual code too. #14379

Merged
merged 1 commit into from
Dec 4, 2023
Merged

docs(inputs.fireboard): Revert typo fix as the typo is returned in the actual code too. #14379

merged 1 commit into from
Dec 4, 2023

Conversation

Hr0bar
Copy link
Contributor

@Hr0bar Hr0bar commented Dec 4, 2023 •
edited by srebhan
Loading

Summary

Reverts typo fix in fireboard plugin docs, because the typo is actually what the code in fact returns as a tag.

Checklist

  • No AI generated code was used in this PR

Related issues

#14359

@telegraf-tiger telegraf-tiger bot added docs Issues related to Telegraf documentation and configuration descriptions plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins labels Dec 4, 2023
srebhan
srebhan approved these changes Dec 4, 2023
View reviewed changes
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this @Hr0bar!

@srebhan srebhan mentioned this pull request Dec 4, 2023
Merged
@srebhan srebhan added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Dec 4, 2023
@powersj powersj merged commit 78e41f6 into influxdata:master Dec 4, 2023
3 of 5 checks passed
@github-actions github-actions bot added this to the v1.29.0 milestone Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@powersj powersj powersj approved these changes

@srebhan srebhan srebhan approved these changes

Assignees

@powersj powersj

Labels
docs Issues related to Telegraf documentation and configuration descriptions plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Milestone
v1.29.0
Development

Successfully merging this pull request may close these issues.
3 participants
@Hr0bar @powersj @srebhan