Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests(parsers.json_v2): Fix timestamp parsing expectations #14335

Closed
wants to merge 1 commit into from
Closed

tests(parsers.json_v2): Fix timestamp parsing expectations #14335

wants to merge 1 commit into from

Conversation

deining
Copy link
Contributor

@deining deining commented Nov 22, 2023

This PR improves and corrects the testdata for parsing of timestamps when using the JSON_V2 parser plugin.

@deining deining force-pushed the improve-timestamp-sample branch from 90a4d7a to a6990a3 Compare November 22, 2023 21:10
@srebhan
Copy link
Member

srebhan commented Nov 23, 2023

Thank you for your contribution @deining! I think the current tests are too relaxed as they are specifying testutil.IgnoreTime() during comparison, so you could basically set any timestamp value in expected.out and the tests will pass.
Could you look into ignoring the timestamp only if no timestamp option was given? I think that would be the best solution and then fix the tests' expected values accordingly...

@srebhan srebhan self-assigned this Nov 23, 2023
@srebhan srebhan changed the title JSON_V2 parser plugin: improve testdata for parsing of timestamps tests(parsers.json_v2): Fix timestamp parsing expectations Nov 23, 2023
@srebhan srebhan added area/json json and json_v2 parser/serialiser related plugin/parser 1. Request for new parser plugins 2. Issues/PRs that are related to parser plugins test labels Nov 23, 2023
@powersj powersj added the waiting for response waiting for response from contributor label Nov 27, 2023
@telegraf-tiger
Copy link
Contributor

Hello! I am closing this issue due to inactivity. I hope you were able to resolve your problem, if not please try posting this question in our Community Slack or Community Forums or provide additional details in this issue and reqeust that it be re-opened. Thank you!

@telegraf-tiger telegraf-tiger bot closed this Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@srebhan srebhan

Labels
area/json json and json_v2 parser/serialiser related plugin/parser 1. Request for new parser plugins 2. Issues/PRs that are related to parser plugins test waiting for response waiting for response from contributor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@deining @srebhan @powersj