feat: upgrade Spring to v6, SpringBoot to v3 #673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
powersj
reviewed
Jan 22, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #673 +/- ##
============================================
- Coverage 88.35% 88.33% -0.03%
- Complexity 777 779 +2
============================================
Files 173 173
Lines 7078 7078
Branches 393 389 -4
============================================
- Hits 6254 6252 -2
Misses 699 699
- Partials 125 127 +2 ☔ View full report in Codecov by Sentry. |
6 tasks
karel-rehor
reviewed
Jan 29, 2024
| @@ -1012,7 +1013,15 @@ void userAgent() throws InterruptedException { | |||
|
|
|||
| String userAgent = recordedRequest.getHeader("User-Agent"); | |||
|
|
|||
| Assertions.assertThat(userAgent).startsWith("influxdb-client-java/7."); | |||
| String currentVersion = UserAgentInterceptor.class.getPackage().getImplementationVersion(); | |||
There was a problem hiding this comment.
Added a test change here. Jakub, does this work for you? Does it not defeat Utku Aydin's intent for this assertion?
karel-rehor
approved these changes
Jan 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #649
Proposed Changes
Migrate
influxdb-springfrom Spring Boot v2 to v3, Spring to v6.Checklist
mvn testcompletes successfully