Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Issue/644 #648

Merged
merged 5 commits into from
Nov 29, 2023
Merged

fix: Issue/644 #648

merged 5 commits into from
Nov 29, 2023

Conversation

karel-rehor
Copy link
Contributor

@karel-rehor karel-rehor commented Nov 24, 2023

Closes #644

Proposed Changes

When FluxCSVParser parses a value, and the stringValue is empty and the default value for the column is empty, now checks whether the data type for the column is "string" and if this is the case returns the empty default value instead of null.

Note that headerless csv tables will still return null and that null will be returned if the default value is null.

Two tests are added to FluxCsvParserTest.

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • A test has been added if appropriate
  • mvn test completes successfully
  • Commit messages are conventional
  • Sign CLA (if not already signed)

@karel-rehor karel-rehor requested a review from bednar November 24, 2023 12:29
Copy link
Contributor

@bednar bednar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your PR! 👍 Could you please update the CHANGELOG.md file to reflect your changes?

@bednar bednar added this to the 6.11.0 milestone Nov 27, 2023
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (19bde3e) 88.36% compared to head (776c67e) 88.36%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #648   +/-   ##
=========================================
  Coverage     88.36%   88.36%           
  Complexity      779      779           
=========================================
  Files           172      172           
  Lines          7022     7024    +2     
  Branches        382      383    +1     
=========================================
+ Hits           6205     6207    +2     
  Misses          698      698           
  Partials        119      119           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@bednar bednar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@bednar bednar merged commit 347003a into master Nov 29, 2023
2 checks passed
@bednar bednar deleted the issue/644 branch November 29, 2023 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The empty string is converted to null
3 participants