Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(conn-pkg): use types for compression in conn pkg #4197

Merged
merged 9 commits into from
Sep 27, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions crates/fluvio-connector-common/src/producer.rs
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,8 @@ pub async fn producer_from_config(config: &ConnectorConfig) -> Result<(Fluvio, T
};

// Compression
if let Some(compression) = producer_params.compression {
config_builder = config_builder.compression(compression)
if let Some(compression) = &producer_params.compression {
config_builder = config_builder.compression(compression.clone())
};

// Batch size
Expand Down
1 change: 0 additions & 1 deletion crates/fluvio-connector-package/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@ fluvio-controlplane-metadata = { path = "../fluvio-controlplane-metadata/", defa
fluvio-smartengine = { path = "../fluvio-smartengine", default-features = false, features = [
"transformation",
] }
fluvio-compression = { path = "../fluvio-compression" }
fluvio-types = { path = "../fluvio-types" }
bytesize-serde = "0.2.1"

Expand Down
2 changes: 1 addition & 1 deletion crates/fluvio-connector-package/src/config/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,8 @@ pub use bytesize::ByteSize;

pub use fluvio_controlplane_metadata::topic::config as topic_config;
pub use fluvio_smartengine::transformation::TransformationStep;
pub use fluvio_compression::Compression;
pub use fluvio_types::PartitionId;
pub use fluvio_types::compression::Compression;

use crate::metadata::Direction;

Expand Down
2 changes: 1 addition & 1 deletion crates/fluvio-types/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ events = ["event-listener"]
event-listener = { workspace = true, optional = true }
thiserror = { workspace = true }
tracing = { workspace = true }
serde = { workspace = true }
serde = { workspace = true, features = ["derive"], default-features = false }
toml = { workspace = true, features = ["display", "preserve_order", "parse"] }

[dev-dependencies]
Expand Down
5 changes: 4 additions & 1 deletion crates/fluvio-types/src/compression.rs
Original file line number Diff line number Diff line change
@@ -1,4 +1,7 @@
#[derive(Clone, Debug, Eq, PartialEq)]
use serde::{Serialize, Deserialize};

#[derive(Clone, Debug, Deserialize, Eq, Serialize, PartialEq)]
#[serde(rename_all = "lowercase")]
pub enum Compression {
None,
Gzip,
Expand Down
Loading