chore: decrease exponential timeout of mirroring #4196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fraidev
force-pushed
the
mirroring_tests_fix_sleep
branch
2 times, most recently
from
6deac59 to
46421a8
Compare
fraidev
changed the title
fraidev
changed the title
fraidev
force-pushed
the
mirroring_tests_fix_sleep
branch
from
46421a8 to
1528f9b
Compare
fraidev
force-pushed
the
mirroring_tests_fix_sleep
branch
5 times, most recently
from
d342cf2 to
ddffa26
Compare
fraidev
force-pushed
the
mirroring_tests_fix_sleep
branch
from
ddffa26 to
d344743
Compare
digikata
reviewed
Sep 27, 2024
|
please add description on what this PR solves |
Actually, my changes on min does even change the behavior, I found out that I propose then change the factor, we were using the default (2), easily to be stressed with only 30 secs. Only needing 6 hits to be totally stressed. I changed the factor to 1.1 that will need 37 hits to be totally stressed! That should improve to not sleeping a lot at first seconds trying to connect. Also make our tests more realiable. |
fraidev
force-pushed
the
mirroring_tests_fix_sleep
branch
from
6d6089e to
1916abb
Compare
digikata
approved these changes
Sep 27, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 28, 2024
* chore: decrease exponential timeout of mirroring * chore: change default factor of mirroring backoff
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
fraidev
force-pushed
the
mirroring_tests_fix_sleep
branch
from
c2cd74c to
1211362
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That should improve to not sleeping a lot at first seconds trying to connect.
Also helping our mirroring tests be more reliable.