FI-2494 POST capability added to granular scopes #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jammjammjamm
reviewed
Mar 6, 2024
| search_method = previous_request.verb.to_sym | ||
| params = search_method == :get ? previous_request.query_parameters : JSON.parse(previous_request.request_body) |
There was a problem hiding this comment.
The body of a POST search is application/x-www-form-urlencoded not JSON.
There was a problem hiding this comment.
Thanks, changed both the rspec test to encode it as such and the parsing here to treat it as application/x-www-form-urlencoded instead of json.
Jammjammjamm
reviewed
Mar 6, 2024
| @@ -133,6 +133,7 @@ def self.metadata | |||
| ).to_json | |||
| ) | |||
| end | |||
|
|
|||
There was a problem hiding this comment.
Remove extra whitespace.
| search_method = previous_request.verb.to_sym | ||
| params = search_method == :get ? previous_request.query_parameters : Hash[URI.decode_www_form(previous_request.request_body)] | ||
| binding.pry if search_method == :post |
|
|
||
| it 'correctly pulls parameters from POST body' do | ||
| response_body = | ||
| FHIR::Bundle.new( |
Jammjammjamm
approved these changes
Mar 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Added inspection of request body if it is a POST request for query parameters.
Wondering about if we will ever expect more in the body than query parameters, i.e. should there be more thorough parsing/decision making here?
Also want to check that POST searches are made to an endpoint that ends in
\_searchevery time? The current spec test uses that endpoint, and I don't think it would impact the functionality, but the spec test wouldn't pass until I added that into the url (fhir_search must automatically add the route when it sees it's a POST?)Testing Guidance
Added a spec test that stubs a post request and returns correct resources, and expects test to pass.