FI-2231 Add searches for Practitioner test #149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| 'Specimen' => ['v610', 'v700_ballot'] | ||
| }.freeze | ||
|
|
||
| SEARCHABLE_NON_USCDI_RESOURCES = { |
There was a problem hiding this comment.
This naming is confusing because Practitioner is a USCDI resource is these versions. Why is Practitioner treated differently than Encounter? Aren't they both resources that weren't USCDI, but then became USCDI?
There was a problem hiding this comment.
Practitioner does not have patient search parameter so it is still a "delayed" resource. I will change the name to SEARCHABLE_DELAYED_RESOURCES
Jammjammjamm
approved these changes
Feb 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes JIRA ticket FI-2231 and GitHub Issue: onc-healthit/onc-certification-g10-test-kit#485. Practitioner is a delayed resource because it does not have patient search parameter and it is not an USCDI data class/data element. (g)(10) test kit excludes search tests for all delayed resources.
To add search tests back for Practitioner in (g)(10) test kit, we split the original "delayed" resources into to part for (g)(10) test kit: delayed resources with searches and delayed resources without searches. The second category is identified by
exclude_search_tests?metadata property.Change Log
is_delayedinto metadata.yml (Note: I am still debating if this is necessary. I could remove this from metadata.yml if there're other opinions)SpecialCasemoduleSEARCHABLE_DELAYED_RESOURCESexclude_search_tests?Testing Guidance
This PR does not affect US Core Test Kit. Corresponding changes are also applied in (g)(10) test kit so that when (g)(10) loads US Core Test Suites, it uses the
exclude_search_tests?property instead ofdelayed?property to decide if group's search tests shall be included/excluded.