FI-2348 Add guard for fixed values on slice discriminators #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not sure if this needs to be more specific -- like if there are cases where a sub element of a slice has a fixed value, but it is not used within the discriminator of the slice. I couldn't find a case in my inspection, but am definitely still learning the ins and outs of US Core structures. |
yunwwang
approved these changes
Dec 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a check in
handle_fixed_valuesthat prevents appending unnecessary information to slice subelement must supports.No change in test output or rspec tests. Elements that are not related to slices that have fixed values are still handled with no changes (see Observation.code for observation_occupation/metadata.yml)