FI-3610 Add redirect_uri config to redirect test #19
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a configuration for the
redirect_uri
to the authorization code redirect test to fix an integration bug when the redirect test is reused in another test kit.Prior to this change, the
redirect_uri
in the UDAP test kit was configured at the suite level but not at the test level. When the redirect test was reused in another test kit, that test kit needed to manually configure aredirect_uri
, otherwise the URI would be blank and the test failed:However, even if that configuration is set in the other test kit, the redirect URI used by the authorization code redirect test must match the value submitted in the dynamic client registration test's software statement, which is the constant
UDAPSecurityTestKit::UDAP_REDIRECT_URI
.Therefore, the
redirect_uri
path must be set and properly exported by the UDAP redirect test in order for the collective set of UDAP tests to work when imported by another test kit.Testing Guidance
To reproduce the bug present in the latest UDAP release (0.10.2):
main
branch, which is currently aligned with the latest releasegit rev-parse --show-toplevel
in the UDAP directory to get the path to the repo for use in step 4FI-3502-update-redirect-test
, which is in a draft PR herebundle config local.udap_security_test_kit </path/to/local/git/repository>
udap_security_test_kit
to bemain
bundle install
in the SMART-UDAP repolocalhost:4567
To demonstrate the bug fix in this branch:
FI-3610-redirect-config-fix
udap_security_test_kit
to beFI-3610-redirect-config-fix
UDAPSecurityTestKit::UDAP_REDIRECT_URI
resolves to#{Inferno::Application['base_url']}/custom/udap_security/redirect
, and the displayed value should behttp://localhost:4567/custom/udap_security/redirect