FI-3166: Step 1 solution upgrade #3
Conversation
elsaperelli
force-pushed
the
step-1-solution-upgrade
branch
from
ed2ae26 to
d98ac7a
Compare
Access token input is showing up twice |
| input :credentials, | ||
| title: 'OAuth Credentials', | ||
| type: :oauth_credentials, | ||
| optional: true | ||
|
|
There was a problem hiding this comment.
I think we want to remove this credentials input and just have the access_token input instead, since the tutorial is explaining how to add the access token input. Another option is to update the tutorial to add a oauth input rather than the bearer token input, but that probably is not necessary
There was a problem hiding this comment.
Decided to leave for now and create separate task!
| # All FHIR requests in this suite will use this FHIR client | ||
| fhir_client do | ||
| url :url | ||
| oauth_credentials :credentials |
There was a problem hiding this comment.
You would need to remove this if we got rid of the oauth_credentials input
| @@ -79,13 +98,13 @@ def run(runnable, inputs = {}) | |||
| response_body: resource.to_json | |||
| ) | |||
|
|
|||
| result = run(test) | |||
| result = run(test, url: url) | |||
There was a problem hiding this comment.
Since the access token input is required, you have to pass in that input as well in all the spec tests so that the test does not skip
Summary
This PR updates the Inferno template version in step-1-solution branch. It includes the solution to step-1 of the tutorial.
Testing
Run locally with Docker:
./run.shin this repositoryhttp://localhosthttps://inferno.healthit.gov/reference-server/r4SAMPLE_TOKEN85Also run with Ruby.