FI-3011: Rest hook notification validation #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
January 8, 2025 14:06
…ions-test-kit into FI-3011-rest-hook-notification-validation
karlnaden
requested changes
Jan 10, 2025
| assert(request.content_type_header == mime_type, | ||
| 'Content type of request does not match the Subscription MIME type') | ||
| # Verification for hl7.fhir.uv.subscriptions_1.1.0@27 | ||
| assert(request.header.include?(subscription&.channel&.header), |
There was a problem hiding this comment.
Subscription.channel.header is a list, so some looping will be needed. Check if include? is the right comparison.
| 'Content type of request does not match the Subscription MIME type') | ||
| # Verification for hl7.fhir.uv.subscriptions_1.1.0@27 | ||
| assert(request.header.include?(subscription&.channel&.header), | ||
| 'Subscriptoin channel header is not conveyed as HTTP request header') |
There was a problem hiding this comment.
typo Subscriptoin -> Subscription
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work in progress - creating a PR as a placeholder
Need to figure out how to test the rest-hook notifications, unsure how to run those tests currently