Skip to content

Commit

Permalink
Update Validator Dependency (#41)
Browse files Browse the repository at this point in the history
* update validation dependency

* test CI with 5.3.14 validator dep

* reorder tests

* reorder and update

* require Java 11

* update fhir validation dependency to latest version

* Change JAVA_HOME to openjdk-11

* comment out line

Co-authored-by: Jack Fraser <[email protected]>
Co-authored-by: Yunwei Wang <[email protected]>
  • Loading branch information
3 people authored Jan 7, 2022
1 parent 4afb7a9 commit 915c7fb
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 8 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/gradle.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
java: [8.x, 11.x, 16.x]
java: [16.x, 11.x]

name: Java ${{ matrix.java }} Build
steps:
Expand Down
6 changes: 3 additions & 3 deletions Dockerfile
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
FROM openjdk:8 AS build
FROM openjdk:11 AS build

# RUN curl -ksSL https://gitlab.mitre.org/mitre-scripts/mitre-pki/raw/master/os_scripts/install_certs.sh | JAVA_HOME=/usr/local/openjdk-8 MODE=java sh
# RUN curl -ksSL https://gitlab.mitre.org/mitre-scripts/mitre-pki/raw/master/os_scripts/install_certs.sh | JAVA_HOME=/usr/local/openjdk-11 MODE=java sh
# If using under Zscalar, comment out the above and run using: 'docker build --no-cache -t hl7_validator .'

WORKDIR /home
Expand All @@ -19,7 +19,7 @@ COPY src src
RUN ./gradlew build
RUN tar -xvf build/distributions/InfernoValidationService-*.tar

FROM openjdk:8
FROM openjdk:11
WORKDIR /home
ENV JAVA_OPTS="-XX:MaxRAMPercentage=75.0"

Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ to other applications that integrate it.

## Installation

**System Requirements:** The Validation Service requires Java 1.8 or above.
**System Requirements:** The Validation Service requires Java 11 or above.

## Running Locally with Java

Expand Down
7 changes: 4 additions & 3 deletions build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ dependencies {
// https://chat.fhir.org/#narrow/stream/179166-implementers/topic/New.20validator.20JAR.20location
// the ig-publisher uses this one too
// https://github.com/HL7/fhir-ig-publisher/blob/master/pom.xml#L68
implementation("ca.uhn.hapi.fhir", "org.hl7.fhir.validation", "5.3.14")
implementation("ca.uhn.hapi.fhir", "org.hl7.fhir.validation", "5.5.10")

// validator dependencies (should be able to get these automatically?)
implementation("org.apache.commons","commons-compress", "1.19")
Expand All @@ -38,8 +38,9 @@ dependencies {
testImplementation("org.junit.jupiter", "junit-jupiter", "5.5.2")
}

configure<JavaPluginConvention> {
sourceCompatibility = JavaVersion.VERSION_1_8
java {
targetCompatibility = JavaVersion.VERSION_11
sourceCompatibility = JavaVersion.VERSION_11
}

application {
Expand Down

0 comments on commit 915c7fb

Please sign in to comment.