Stop swallowing all exceptions in settings.py #256
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stop swallowing all exceptions. Likely we'll need to explicitly catch a handful of exceptions, but at this point we're not sure which ones they are. Fix #139
jeffwidman
changed the title
|
Thanks for your contribution! The tests failed--could you take a look? |
|
Yeah, I saw that. I definitely will fix, although probably won't have time until next week after pycon. |
|
I think this can be closed- the exceptions are being logged now. |
|
Agreed, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stop swallowing all exceptions in
settings.py.This is a broader swath than the original issue which only discussed removing the bare
try/exceptfromload_config(). However, I can envision the same type of problem happening insave_config()resulting in someone being confused why their configs aren't being saved.Likely we'll need to explicitly catch a handful of exceptions, but at this point we're not sure which ones they are.
I'm also very open to reworking this to only remove the one
try/exceptclause, but I figured might as well start the conversation by trying to fix all the things... 😄Fix #139