fix(MenuItem): router link to computed href (#67)

indielayer · Apr 12, 2024 · 50c7cf9 · 50c7cf9
1 parent fc3cfad
commit 50c7cf9
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/.changeset/famous-glasses-dream.md b/.changeset/famous-glasses-dream.md
@@ -0,0 +1,5 @@
+---
+"@indielayer/ui": patch
+---
+
+fix(MenuItem): router link to computed href
diff --git a/packages/ui/src/components/menu/MenuItem.vue b/packages/ui/src/components/menu/MenuItem.vue
@@ -127,9 +127,11 @@ const { styles, classes, className } = useTheme('MenuItem', {}, computedProps, {
   <component
     :is="htmlTag"
     ref="elRef"
-    v-bind="computedProps.attrs"
+    v-bind="{
+      ...(computedProps.href ? { href: computedProps.href } : {}),
+      ...computedProps.attrs,
+    }"
     :to="computedProps.to"
-    :href="computedProps.href || computedProps.to || ''"
     :target="computedProps.target"
     :color="computedProps.color"
     :style="styles"