Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update runner.go so it can handle expired error from watches #7

Conversation

mbarrin-incident
Copy link

No description provided.

@mbarrin-incident mbarrin-incident force-pushed the matthewbarrington/inf-1277-fix-issues-with-theatre-pod-watches-expiring branch 2 times, most recently from 0dc6069 to ba09886 Compare December 11, 2024 17:49
pkg/workloads/console/runner/runner.go Outdated Show resolved Hide resolved
pkg/workloads/console/runner/runner.go Outdated Show resolved Hide resolved
pkg/workloads/console/runner/runner.go Outdated Show resolved Hide resolved
pkg/workloads/console/runner/runner.go Show resolved Hide resolved
pkg/workloads/console/runner/runner.go Outdated Show resolved Hide resolved
@mbarrin-incident mbarrin-incident force-pushed the matthewbarrington/inf-1277-fix-issues-with-theatre-pod-watches-expiring branch 3 times, most recently from e282019 to 69c42db Compare December 12, 2024 13:42
We are currently getting issues on a regular basis with pods succeeding,
but Theatre thinking there were issues.

This updates the code to have a specific handling of the expire error,
and to retry 2 more times, with growing backoff.
@mbarrin-incident mbarrin-incident force-pushed the matthewbarrington/inf-1277-fix-issues-with-theatre-pod-watches-expiring branch from 69c42db to a679420 Compare December 12, 2024 14:03
Copy link

@benwh benwh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think this looks legit - let's try it!

pkg/workloads/console/runner/runner.go Outdated Show resolved Hide resolved
pkg/workloads/console/runner/runner.go Outdated Show resolved Hide resolved
pkg/workloads/console/runner/runner.go Outdated Show resolved Hide resolved
@mbarrin-incident mbarrin-incident merged commit 8571d8c into master Dec 12, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants