feat(app): replace staking with dogfood #42
Conversation
since that is handled by operator keeper
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
Test the commit af27899 with bootstrap test, passed.
|
this causes a panic
| ret := am.keeper.EndBlock(ctx) | ||
| am.keeper.TrackHistoricalInfo(ctx) | ||
| return ret | ||
| return am.keeper.EndBlock(ctx) |
Check warning
Code scanning / CodeQL
Panic in BeginBock or EndBlock consensus methods Warning
TODO: `cmd/exocored/testnet.go`
Also comment out x/oracle tests for now
| var ithPeers []string | ||
| for j := 0; j < args.numValidators; j++ { | ||
| if i != j { | ||
| ip, _ := getIP(j, args.startingIPAddress) |
Check warning
Code scanning / gosec
Returned error is not propagated up the stack. Warning test
|
|
||
| // x/operator initialization - address only | ||
| privkey, _ := ethsecp256k1.GenerateKey() | ||
| key, _ := privkey.ToECDSA() |
Check warning
Code scanning / gosec
Returned error is not propagated up the stack. Warning test
|
|
||
| // x/operator initialization - address only | ||
| privkey, _ := ethsecp256k1.GenerateKey() |
Check warning
Code scanning / gosec
Returned error is not propagated up the stack. Warning test
| bondAmt := sdk.DefaultPowerReduction | ||
| // x/operator initialization - address only | ||
| privkey, _ := ethsecp256k1.GenerateKey() | ||
| key, _ := privkey.ToECDSA() |
Check warning
Code scanning / gosec
Returned error is not propagated up the stack. Warning
|
|
||
| bondAmt := sdk.DefaultPowerReduction | ||
| // x/operator initialization - address only | ||
| privkey, _ := ethsecp256k1.GenerateKey() |
Check warning
Code scanning / gosec
Returned error is not propagated up the stack. Warning
The dogfood module is designed to act as a drop-in replacement for the staking module. This PR enables that usage, and at the same time, helps rationalize parts of
app/app.goby providing comments about each module and their orders (begin / end / genesis) within the overall system.TODO: update the following things to remove reliance on staking module.
local_node.shexocored testnet init-filesapp/ethtest_helper.goapp/test_helpers.goTODO: testing of cross-chain communication.