chore(lint): placate the linting overlords

x/assets/keeper/genesis.go

@@ -7,24 +7,34 @@ import (
 
 // InitGenesis initializes the module's state from a provided genesis state.
 func (k Keeper) InitGenesis(ctx sdk.Context, data *types.GenesisState) {
-	k.SetParams(ctx, &data.Params)
+	if err := k.SetParams(ctx, &data.Params); err != nil {
+		panic(err)
+	}
 	// client_chain.go
-	for _, info := range data.ClientChains {
-		k.SetClientChainInfo(ctx, &info)
+	for _, infoCopy := range data.ClientChains {
+		info := infoCopy // prevent implicit memory aliasing
+		if err := k.SetClientChainInfo(ctx, &info); err != nil {
+			panic(err)
+		}
 	}
 	// client_chain_asset.go
-	for _, info := range data.Tokens {
-		k.SetStakingAssetInfo(ctx, &info)
+	for _, infoCopy := range data.Tokens {
+		info := infoCopy // prevent implicit memory aliasing
+		if err := k.SetStakingAssetInfo(ctx, &info); err != nil {
+			panic(err)
+		}
 	}
 	// operator_asset.go
 	for _, level1 := range data.OperatorAssetInfos {
 		// we have validated previously that the address is
 		// the bech32 encoded address of sdk.AccAddress
 		addr := level1.OperatorAddress
 		for _, info := range level1.AssetIdAndInfos {
-			k.SetOperatorAssetInfo(
+			if err := k.SetOperatorAssetInfo(
 				ctx, addr, info.AssetID, info.Info,
-			)
+			); err != nil {
+				panic(err)
+			}
 		}
 	}
 	// staker_asset.go

x/assets/types/genesis.go

@@ -280,6 +280,9 @@ func areMapsIdentical(m1, m2 map[string]math.Int) bool {
 		return false
 	}
 
+	// this code is not consensus critical, so we can loop.
+	// the codeQL warning can be ignored.
+	// nolint:gosec
 	for k1, v1 := range m1 {
 		v2, ok := m2[k1]
 		if !ok || !v1.Equal(v2) {

x/delegation/keeper/genesis.go

@@ -20,7 +20,7 @@ func (k Keeper) InitGenesis(
 			assetID := b.AssetID
 			for _, c := range b.DelegationsByOperator {
 				operatorAddress := c.OperatorAddress
-				// already validated in genState.Validate()
+				// #nosec G703 // already validated
 				accAddress, _ := sdk.AccAddressFromBech32(operatorAddress)
 				amount := c.Amount
 				if !k.operatorKeeper.IsOperator(ctx, accAddress) {

x/dogfood/keeper/genesis.go

@@ -32,7 +32,7 @@ func (k Keeper) InitGenesis(
 	}
 	out := make([]abci.ValidatorUpdate, len(genState.InitialValSet))
 	for _, val := range genState.InitialValSet {
-		// already validated
+		// #nosec G703 // already validated
 		consKey, _ := operatortypes.HexStringToPubKey(val.PublicKey)
 		out = append(out, abci.ValidatorUpdate{
 			PubKey: *consKey,

x/operator/keeper/genesis.go

@@ -8,12 +8,13 @@ import (
 
 func (k Keeper) InitGenesis(ctx sdk.Context, state types.GenesisState) []abci.ValidatorUpdate {
 	// operators.go
-	for _, info := range state.Operators {
+	for _, infoCopy := range state.Operators {
+		info := infoCopy // prevent implicit memory aliasing
 		if err := k.SetOperatorInfo(ctx, info.EarningsAddr, &info); err != nil {
 			panic(err)
 		}
 		operatorAddress := info.EarningsAddr
-		// already validated during state.Validate()
+		// #nosec G703 // already validated
 		operatorAccAddress, _ := sdk.AccAddressFromBech32(operatorAddress)
 		if err := k.OptIn(ctx, operatorAccAddress, ctx.ChainID()); err != nil {
 			panic(err)
@@ -22,11 +23,11 @@ func (k Keeper) InitGenesis(ctx sdk.Context, state types.GenesisState) []abci.Va
 	// consensus_keys.go
 	for _, record := range state.OperatorRecords {
 		operatorAddress := record.OperatorAddress
-		// already validated during state.Validate()
+		// #nosec G703 // already validated
 		operatorAccAddress, _ := sdk.AccAddressFromBech32(operatorAddress)
 		for _, subRecord := range record.Chains {
 			consKeyBytes32 := subRecord.ConsensusKey
-			// already validated
+			// #nosec G703 // already validated
 			consKey, _ := types.HexStringToPubKey(consKeyBytes32)
 			if err := k.SetOperatorConsKeyForChainID(
 				ctx, operatorAccAddress, subRecord.ChainID, consKey,