-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: improved builder pattern for RequestUrl #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c3f4839
to
79053a2
Compare
f44f865
to
7a0644b
Compare
df16767
to
a1031d2
Compare
daniel-mader
previously approved these changes
Jun 9, 2023
Add tests for RequestUrl Add missing request parameters Add sphereon demo website test Update documentation with new RequestUrl Remove sphereon demo example Add validate_request method to Provider struct Add preoper Ser and De for SiopRequest and RequestBuilder Add skeptic for Markdown code testing Add support for Request by reference fix: fix rebase conflicts Add comments and fix some tests fix: Move `derivative` to dev-dependencies Refactor Provider and Subject improve tests and example using wiremock Improve struct field serde fix: remove claims from lib.rs style: fix arguments order Add did:key DID method Add support for Request by reference fix: Remove lifetime annotations Add preoper Ser and De for SiopRequest and RequestBuilder Add Scope and Claim fix: fix rebase conflicts
Add tests for RequestUrl Add missing request parameters Add sphereon demo website test Update documentation with new RequestUrl Remove sphereon demo example Add validate_request method to Provider struct Add preoper Ser and De for SiopRequest and RequestBuilder Add skeptic for Markdown code testing Add support for Request by reference fix: fix rebase conflicts Add comments and fix some tests fix: Move `derivative` to dev-dependencies Refactor Provider and Subject improve tests and example using wiremock Improve struct field serde fix: remove claims from lib.rs style: fix arguments order Add did:key DID method Add support for Request by reference fix: Remove lifetime annotations Add preoper Ser and De for SiopRequest and RequestBuilder Add Scope and Claim fix: fix rebase conflicts
a1031d2
to
c2d01e0
Compare
daniel-mader
approved these changes
Jun 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
#26 should be merged first.
Added
RequestObject
variant toRequestUrl
enum. The three variants of the enum now reflect the 3 possible ways to transfer authorization request parameters with the Provider:RequestUrl::Request
: All request parameters are directly represented via anAuthorizationRequest
RequestUrl::RequestUri
: The request parameters are encoded into a Request Object (JWT) and hosted at an endpoint. The only parameters that are initially transferred to the provider areclient_id
andrequest_uri
, which represents the endpoint wher the provider can obtain the actual Request Object.RequestUrl::RequestObject
: In this case, the actual request parameters are also encoded into a Request Object (JWT), but now this JWT is directly transferred to the provider as a value for therequest
parameter alongside theclient_id
parameter.More info: https://www.rfc-editor.org/rfc/rfc9101.html#section-5
Links to any relevant issues
#19
How the change has been tested
Adjusted some existing unit-tests that relied on RequestBuilder
Added
test_valid_request_object
unit test.Definition of Done checklist
Add an
x
to the boxes that are relevant to your changes.