Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update webview peer dependecy to match >11 versions and allow configuring readonly mode #124

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

wtomaszewski-applause
Copy link

There is a peer dependency for "react-native-webview": "^11.0.0" which doesn't allow to install library where the library is imported to project which uses >11 react-native-webview version (npm 8+). There is a workaround to use npm install --legacy-peer-deps but that is not recommended.

There is also a change to allow passing readonly property which applies readOnly mode for quill and the text is not editable. There is existing issue which is related to that topic so I think that will be a good improvement: #86

@wtomaszewski-applause wtomaszewski-applause force-pushed the feature/readonly branch 4 times, most recently from 5a9d491 to 9a4e3ea Compare November 14, 2023 10:03
@wtomaszewski-applause
Copy link
Author

@imnapo could you take a look at that changes?

@ehud-qlog
Copy link

@imnapo, is this fix coming? It has been open for a long time and is important for anyone using newer versions of WebView.

@pecabum
Copy link

pecabum commented Jul 30, 2024

I am also waiting for this fix

Copy link

@Rohit-Parte Rohit-Parte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wtomaszewski-applause Can you please update value of dataDetectorTypes in renderWebview > WebView function to manage to work with [email protected].

In this version of react-native-webview, they've updated dataDetectorTypes type to array.

@Rohit-Parte
Copy link

This PR must be merged as it has huge dependency on react-native-webview latest version.

For work around, I'm able to get it done by changing value of dataDetectorTypes='none' to dataDetectorTypes={["none"]} in quill-editor.tsx > renderWebview > WebView. And imported this library outside node_modules as

import QuillEditor, { QuillToolbar } from '../../components/react-native-cn-quill/src';

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants