docs: add-current-path-to-version-switcher #15860
Draft
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
documentation
|
This updates the feature added in #10091 |
NicholasFlamy
commented
Feb 2, 2025
| @@ -49,7 +49,7 @@ export default function VersionSwitcher(): JSX.Element { | |||
| mobile={windowSize === 'mobile'} | |||
| items={versions.map(({ label, url }) => ({ | |||
| label, | |||
| to: url, | |||
| to: url + location.pathname, | |||
There was a problem hiding this comment.
I figured this was the simplest way to do it.
There was a problem hiding this comment.
If using a var equal to location.pathname and then referencing that var here is better, let me know.
|
📖 Documentation deployed to pr-15860.preview.immich.app |
|
I'm not sure about the official docs build process. I know that for the initial implementation of the version switcher that it only had the current docs but older docs were added shortly after. The older docs had to be modified with the version switcher. This PR would need to take effect on the archived docs. |
NicholasFlamy
force-pushed
the
docs-version-switcher-use-current-path
branch
from
3ba3c5c to
7eb6ecc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the path of the page you are on to the version switcher options so that you can quickly view changes on the page you are on.