-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(mobile): allow contact picking for names in mobile app #15817
base: main
Are you sure you want to change the base?
Conversation
Hello, this is very cool! |
I've since done some other designs but was actually the most satisfied with this one. I'm marking this as open for review. |
I understand this only checks the Android phone local contacts. What about:
|
This uses https://pub.dev/packages/fast_contacts so it should work on iOS too. I don't have an iPhone, so I couldn't test it. Maybe someone else can? Merging faces is possible but imho that should be a separate PR? |
Thanks for spotting! I fixed the keyboard issue, also set the dialog width to After first time (after asking for the permission) keyboard can still be hidden, though it works fine after that. I couldn't get it to show right after clicking on the permission dialog though. |
To be clear, it works fine for me if I allowed the Contacts permission. The video is after I denied Contacts permission and Android doesn't allow the app to ask again (cause I denied at least twice in a row). Edit: I will test this again when I get home. |
Yeah, got that - it should be fixed with the above commits :). |
It behaves correctly now. There is a very slight stutter while it opens so I need to build a release apk and test that to confirm if it's this PR or if it's just the debug build being JIT or wtv. |
Good job! It works great! No issues with the permission allowed or denied. |
Co-authored-by: Nicholas Flamy <[email protected]>
Hi there!
I love immich but thought it could use a minor improvement when naming your persons. If you do it via mobile app, we have access to user's contact list, so we can use it to suggest people names.
I've implemented that, you can see how it looks in the attached screenshots:
![](https://private-user-images.githubusercontent.com/34912839/408739859-3ec01458-a3d0-45ee-b654-ec7dce442430.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk0OTExMTYsIm5iZiI6MTczOTQ5MDgxNiwicGF0aCI6Ii8zNDkxMjgzOS80MDg3Mzk4NTktM2VjMDE0NTgtYTNkMC00NWVlLWI2NTQtZWM3ZGNlNDQyNDMwLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTMlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjEzVDIzNTMzNlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWIyMTRhZTk2MWRlNGZiNWIwOGE2MjkxNmU5ZGYyYmJhZmU3M2Q0ODYzZTMyODU0YmE1NzU1YzQ5NjEyNTRjMWEmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.anGSfwZ1e0Uum747x8WZN6rfpYKejz98JdOPDXzYUhs)
Here's a (very blurred) video as well, I had little time to edit but I hope you get the point:
immich.mp4
Edit: better video with some fake contacts:
screen-20250205-110824.mp4
I'm opening this as a draft as design (especially of dropdown) can be improved and I'd like to get a feedback on what you think