fix(mobile): deletion of single assets #15597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Saschl
force-pushed
the
fix/image-deletion
branch
from
bd341e9 to
de150d3
Compare
|
Not setting the current asset in |
Understood, this should be probably reverted then as it could cause other issues. |
vladd11
pushed a commit
to vladd11/immich
that referenced
this pull request
Jan 25, 2025
fix: set asset in currentassetprovider on image load Co-authored-by: Alex <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14623
When deleting a picture, the app jumps to the next image, but the reference to the asset is not updated in currentAssetProvider (which is used by the delete functionality), but only after swiping to another image (onPageChanged callback). That means it will try to delete the same image again when hitting the delete button the next time.
Note: I'm not sure this is the right approach here, but I'm happy to take hints and will also look further, hence the draft