Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(server): query fixes #15509

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(server): query fixes #15509

wants to merge 1 commit into from
+275 −165

Conversation

mertalev
Copy link
Contributor

@mertalev mertalev commented Jan 22, 2025 •
edited
Loading

Description

  • Stacked assets duplicated in the timeline
  • Asset stack relation not filtering deleted or archived assets
  • Time bucket endpoints not using tagId field
  • Tag view returning all assets for any tag
  • Library statistics not working
  • Increase per-year asset limit from 10 to 20 for memories
  • Methods passing possibly empty arrays without checking
  • Album asset relation not filtering deleted or archived assets
  • Various typing fixes, a few that have practical implications because of strict === null comparisons

@mertalev mertalev mentioned this pull request Jan 22, 2025
Open
@alextran1502
Copy link
Contributor

Discovered a bug

  1. Make a stack
  2. Go to detail viewer, and open the info panel
  3. Go to the next item in the stack, you will see NO EXIF INFO available, even when navigate back to the primary asset of the stack

@alextran1502
Copy link
Contributor

alextran1502 commented Jan 22, 2025 •
edited
Loading

Found another bug that is probably related to the bug above

  1. Favorite two assets
  2. Stack them
  3. Go to the Favorites page. You are presented with two separate assets. You can click on the primary assets of the stack but will receive a 400 Asset not found error when click on the member of the stack

I narrow it down to this condition in asset.entity.ts

image

jrasm91
jrasm91 reviewed Jan 22, 2025
View reviewed changes
server/src/services/person.service.ts Outdated Show resolved Hide resolved
server/src/services/person.service.ts Outdated Show resolved Hide resolved
server/src/repositories/asset.repository.ts Outdated Show resolved Hide resolved
server/src/repositories/asset.repository.ts Outdated Show resolved Hide resolved
@mertalev
Use tagId option
e49cb70 
fix time bucket stack relation

fix library statistics

fix empty array updates

more fixes

early return for `getFacesByIds`

remove unused import

update types

extract tag id fragment to helper method

generate sql

inline `withStack`
@mertalev mertalev force-pushed the fix/server-kysely-fixes branch from 90b17c4 to e49cb70 Compare January 22, 2025 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrasm91 jrasm91 jrasm91 left review comments

@danieldietzler danieldietzler Awaiting requested review from danieldietzler danieldietzler is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
changelog:skip 🗄️server
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mertalev @alextran1502 @jrasm91