refactor: migrate partner repo to kysely #15366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrasm91
force-pushed
the
refactor/migrate-partner
branch
from
11b3bb7 to
1a505ad
Compare
mertalev
reviewed
Jan 15, 2025
Comment on lines
+41
to
+42
| .select(withSharedBy) | ||
| .select(withSharedWith) |
There was a problem hiding this comment.
Suggested change
| .select(withSharedBy) | |
| .select(withSharedWith) | |
| .select((eb) => jsonObjectFrom(eb.selectFrom('sharedBy').select(columns)).as('sharedBy')) | |
| .select((eb) => jsonObjectFrom(eb.selectFrom('sharedWith').select(columns)).as('sharedWith')) |
withSharedBy/withSharedWith effectively repeat the work that the inner joins do, so it's better to select from the already-joined tables.
alextran1502
approved these changes
Jan 17, 2025
ExceptionsOccur
pushed a commit
to ExceptionsOccur/immich
that referenced
this pull request
Jan 18, 2025
vladd11
pushed a commit
to vladd11/immich
that referenced
this pull request
Jan 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.