Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: migrate access repo to kysely #15365

Merged
merged 12 commits into from
Jan 16, 2025
Merged

Conversation

alextran1502
Copy link
Contributor

@alextran1502 alextran1502 commented Jan 15, 2025

No description provided.

Copy link
Contributor

@jrasm91 jrasm91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is the activity e2e test failling? I don't think it's related to any of the changes you made here.

server/src/repositories/access.repository.ts Show resolved Hide resolved
server/src/repositories/access.repository.ts Show resolved Hide resolved
Comment on lines 117 to 119
console.log('isOwner', isOwner);
const isAlbumOwner = await access.activity.checkAlbumOwnerAccess(auth.user.id, setDifference(ids, isOwner));
console.log('isAlbumOwner', isAlbumOwner);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you delete these?

Copy link
Contributor

@jrasm91 jrasm91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And this one

@alextran1502 alextran1502 merged commit 378bd3c into main Jan 16, 2025
36 checks passed
@alextran1502 alextran1502 deleted the refactor-access-repo-to-kysely branch January 16, 2025 15:25
vladd11 pushed a commit to vladd11/immich that referenced this pull request Jan 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants