Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(web): suppress album upload notification #10717

Merged
merged 3 commits into from
Jul 1, 2024

Conversation

alextran1502
Copy link
Contributor

No description provided.

@alextran1502 alextran1502 requested a review from jrasm91 July 1, 2024 02:58
@alextran1502 alextran1502 enabled auto-merge (squash) July 1, 2024 02:58
Copy link
Contributor

@jrasm91 jrasm91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine for now at least.

onClick() {
return goto(`${AppRoute.ALBUMS}/${albumId}`);

if (showNotification) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe doing if(!showNotifications) { return }; would be better (everything else stays not indented)

@alextran1502 alextran1502 merged commit 4193b0d into main Jul 1, 2024
22 of 23 checks passed
@alextran1502 alextran1502 deleted the fix/web/suppress-album-upload-notification branch July 1, 2024 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants