feat(web): show favorite icon in duplicate asset #10688
Conversation
| @@ -38,6 +38,13 @@ | |||
| draggable="false" | |||
| /> | |||
|
|
|||
| <!-- FAVORITE ICON --> | |||
| {#if !isSharedLink() && asset.isFavorite} | |||
There was a problem hiding this comment.
I don't actually understand why the !isSharedLink is here. I copied this snippet from thumbnail.svelte so I'm guessing we also need this condition here? Let me know if I should take it out 😄
There was a problem hiding this comment.
You don't need it. We hide those types of icons when you are viewing stuff as an anonymous user.
There was a problem hiding this comment.
okay, I've removed the condition
|
Nice job, thanks! |
alextran1502
changed the title
|
Nice! Imo having the favorite icon always be in a consistent place would be nice, feel free to move the view button out of the way to another corner if you want. |
|
@bo0tzz okay I moved the heart back to As for the view button, the only thing in immich that i could kinda consider a precedent to guide its placement is the select button in the asset grid, so I chose to place it in the top left just like the select button.
It's not really the same functionality (select vs view) but overall this feels the least inconsistent to me. What do you think? |
This show the favorite-heart on the duplicate review page:
Note that here it is shown in the top left rather than the bottom left, because the view button is already located in the bottom right. I also experimented with moving the heart up above the view button, but that didn't look as nice in my opinion:
Feel free to object if you think otherwise.
I think this change would be beneficial for the following reason: When reviewing duplicates, I find it useful to know if one of the assets is favorited, because in that case I would then want to ensure afterwards that the asset that I keep is favorited. That way I avoid losing information during the cleanup, i.e. the "isFavorite" information.
What do you think about this suggested change?