refactor: move /server-info endpoints to /server #10677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zackpollard
force-pushed
the
chore/server-info-to-server
branch
2 times, most recently
from
4af4b87 to
087a4a2
Compare
danieldietzler
approved these changes
Jun 28, 2024
zackpollard
force-pushed
the
chore/server-info-to-server
branch
from
087a4a2 to
b1f041d
Compare
jrasm91
approved these changes
Jun 28, 2024
zackpollard
force-pushed
the
chore/server-info-to-server
branch
3 times, most recently
from
e1b16dc to
c5b2a72
Compare
zackpollard
force-pushed
the
chore/server-info-to-server
branch
from
c5b2a72 to
e51a7d6
Compare
alextran1502
approved these changes
Jun 28, 2024
Closed
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves the /server-info endpoints to /server. After a recent discussion between @jrasm91 and I we decided having -info doesn't really make sense and restricts us to only having GET endpoints here really for "information" endpoints. We have upcoming PUT/POST/DELETE endpoints we want to put in the server context, so refactoring this to prepare for that.
These changes preserve /server-info and /server for the time being, with only /server-info being included in the generated APIs. This will allow forward and backwards compatibility and we will remove /server-info and default to /server in a few versions time.