chore(deps): use full semver docker tag for node images #10613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrasm91
changed the title
jrasm91
changed the title
danieldietzler
approved these changes
Jun 25, 2024
bo0tzz
approved these changes
Jun 25, 2024
There was a problem hiding this comment.
Definitely better to set the full tag, yeah.
Note that pinDigests is enabled so renovate will create PRs to add shas again:
Line 3 in d7a33c8
That probably was intentionally left out as it's just easier to let renovate add the hashs later than having to look them up yourself :D |
zackpollard
force-pushed
the
deps/node-tag
branch
from
7af897d to
1a8573d
Compare
|
I thought the intention was to remove the hash, that's why I mentioned it. If we wanna keep it then that's fine of course. |
Co-authored-by: bo0tzz <[email protected]>
zackpollard
approved these changes
Jun 25, 2024
bo0tzz
approved these changes
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrate to tags with full semver (with the idea that renovate PRs should update the tags with the actual version bumps, instead of just changing the hash).
If this works, I can make a separate PR in the base-images repo.