Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(web): show face's border on hovered #10469

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

oezgueremir
Copy link

A new PR for a new branch...the other branch had some unrecoverable issues.

For Screenshots, see #10413

When watching photos and the info tab (detail-panel) is open, all the faces in the photo are marked.

tasks:

  • the "mark all faces" function can be de-/activated on the info tab.
  • CircleIconButton mark_all_faces with mdiLabelMultiple icon as controller.
  • Each person/face has a different, static border color given. This is provided with a little quick'n'dirty solution. A better solution could/would require changes in the DB model...
  • The mouseover event will override that functionallity and mark only the faces of this single person. More over, it will change the visualization of the marking rectangle to border=white, filling=person/face color, opacity=0.6
  • If mark_all_faces is active, the CircleIconButton show_hidden_people will always be available. So you are able to see even hidden and unassigned faces. Hidden and unassigned faces will be visualized, as if the mouseover event is triggered for them. It can be further evaluated, if these two states have to be controlled individually and presented with unique designs.

… faces in the photo are marked.

tasks:
- [x] the "mark all faces" function can be de-/activated on the info tab.
- [x] CircleIconButton mark_all_faces with mdiLabelMultiple icon as controller.
- [x] Each person/face has a different, static border color given.
      This is provided with a little quick'n'dirty solution. A better solution could/would require changes in the DB model...
- [x] The mouseover event will override that functionallity and mark only the faces of this single person.
      More over, it will change the visualization of the marking rectangle to border=white, filling=person/face color, opacity=0.6
- [x] If mark_all_faces is active, the CircleIconButton show_hidden_people will always be available.
      So you are able to see even hidden and unassigned faces.
      Hidden and unassigned faces will be visualized, as if the mouseover event is triggered for them.
      It can be further evaluated, if these two states have to be controlled individually and presented with unique designs.
@mertalev
Copy link
Contributor

I think it'd look cleaner if the boxes were all white without the different colors. It's not like there's usually multiple faces of a single person in an image; it's generally safe to assume each box is a different person.

@oezgueremir
Copy link
Author

Usually and ideally, yes.
But, and this is where this use case comes from, in many group photos in my library (especially pictures of my children), some people have multiple faces assigned to them.
This feature is not meant for every-day usage. This feature is intended to help you find and fix such problems.

@waclaw66
Copy link
Contributor

Nice feature, colored rectangles in people list should be deactivated by default though. It would be cleaner to show them when Mark all faces is activated by clicking that button. Filling face background is quite distracting when a light background color is used under white text person name, I would preffer to make colored border only (first 3 faces).

obrazek

- [x] In people list, don't fill face background, only draw a border around the thumbnail.
- [x] In people list, only draw border, if "mark all faces" option is active
@oezgueremir
Copy link
Author

Nice feature, colored rectangles in people list should be deactivated by default though. It would be cleaner to show them when Mark all faces is activated by clicking that button. Filling face background is quite distracting when a light background color is used under white text person name, I would preffer to make colored border only (first 3 faces).

Ok, this is if the option is not active:
grafik

After activation the option (to emphesize my use case, I mapped two pairs of different faces on a single person):
grafik

How do you like the mouse-over for the visualization in the actual picture be handled?

Currently the style is,
border=white, filling=person/face color, opacity=0.6
grafik

This style is used, even if the option is not active. The intention is, to make it always easy to spot all markings in the picture.
grafik

This would be the style in the released version, same two faces marked as the screenshot before
grafik

The style could be bound to the same switch, or to another (global) setting, or (my preference) just always use the new style. With no additional switches to consider.

@kingvuke
Copy link

kingvuke commented Jul 10, 2024

Will this be taken over? What is the plan?
I really like that! And i think it is helpful!

@alextran1502 alextran1502 enabled auto-merge (squash) October 29, 2024 05:29
@alextran1502 alextran1502 changed the title feat(web): mark all faces v2 - supersedes PR #10413 feat(web): show face's border on hovered Oct 29, 2024
@alextran1502 alextran1502 disabled auto-merge October 29, 2024 05:35
@DrD4ffy
Copy link

DrD4ffy commented Nov 19, 2024

I agree with @mertalev. What about something like this:
frame

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants