-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(web): show face's border on hovered #10469
base: main
Are you sure you want to change the base?
Conversation
… faces in the photo are marked. tasks: - [x] the "mark all faces" function can be de-/activated on the info tab. - [x] CircleIconButton mark_all_faces with mdiLabelMultiple icon as controller. - [x] Each person/face has a different, static border color given. This is provided with a little quick'n'dirty solution. A better solution could/would require changes in the DB model... - [x] The mouseover event will override that functionallity and mark only the faces of this single person. More over, it will change the visualization of the marking rectangle to border=white, filling=person/face color, opacity=0.6 - [x] If mark_all_faces is active, the CircleIconButton show_hidden_people will always be available. So you are able to see even hidden and unassigned faces. Hidden and unassigned faces will be visualized, as if the mouseover event is triggered for them. It can be further evaluated, if these two states have to be controlled individually and presented with unique designs.
I think it'd look cleaner if the boxes were all white without the different colors. It's not like there's usually multiple faces of a single person in an image; it's generally safe to assume each box is a different person. |
Usually and ideally, yes. |
Nice feature, colored rectangles in people list should be deactivated by default though. It would be cleaner to show them when Mark all faces is activated by clicking that button. Filling face background is quite distracting when a light background color is used under white text person name, I would preffer to make colored border only (first 3 faces). |
- [x] In people list, don't fill face background, only draw a border around the thumbnail. - [x] In people list, only draw border, if "mark all faces" option is active
Will this be taken over? What is the plan? |
I agree with @mertalev. What about something like this: |
A new PR for a new branch...the other branch had some unrecoverable issues.
For Screenshots, see #10413
When watching photos and the info tab (detail-panel) is open, all the faces in the photo are marked.
tasks: